apoorvmittal10 commented on code in PR #17656:
URL: https://github.com/apache/kafka/pull/17656#discussion_r1825847778
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##########
@@ -539,7 +539,7 @@ public void onNewMetadataImage(MetadataImage newImage,
MetadataDelta delta) {
}
private TopicPartition topicPartitionFor(SharePartitionKey key) {
- return new TopicPartition(Topic.SHARE_GROUP_STATE_TOPIC_NAME,
partitionFor(key.toString()));
+ return new TopicPartition(Topic.SHARE_GROUP_STATE_TOPIC_NAME,
partitionFor(key.asCoordinatorKey()));
Review Comment:
> Yes thats true but it might not be a good fit since topicName is always
(or mostly) null.
And why is that? For the calls from SharePartition we can fill up topicName
as well. We do a metadata read to verify first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
