chia7712 commented on code in PR #17665:
URL: https://github.com/apache/kafka/pull/17665#discussion_r1826930911
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -11111,7 +11111,7 @@ class KafkaApisTest extends Logging {
kafkaApis.handle(requestChannelRequest, RequestLocal.noCaching)
val expectedHeartbeatResponse = new ConsumerGroupHeartbeatResponseData()
- .setErrorCode(Errors.UNSUPPORTED_VERSION.code)
+ .setErrorCode(Errors.UNKNOWN_SERVER_ERROR.code)
Review Comment:
this test case is used to verify the following check.
```java
def isConsumerGroupProtocolEnabled(): Boolean = {
groupCoordinator.isNewGroupCoordinator &&
config.groupCoordinatorRebalanceProtocols.contains(Group.GroupType.CONSUMER) &&
groupVersion().isConsumerRebalanceProtocolSupported
}
```
That means we should create kafkaApis based on KRaft in this test case,
rather than just changing the error code.
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -11245,7 +11245,7 @@ class KafkaApisTest extends Logging {
consumerGroupDescribeRequestData.groupIds.add(groupId)
val requestChannelRequest = buildRequest(new
ConsumerGroupDescribeRequest.Builder(consumerGroupDescribeRequestData,
true).build())
- val errorCode = Errors.UNSUPPORTED_VERSION.code
+ val errorCode = Errors.UNKNOWN_SERVER_ERROR.code
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
