chirag-wadhwa5 commented on code in PR #17573:
URL: https://github.com/apache/kafka/pull/17573#discussion_r1827272772
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -182,6 +200,15 @@ private static void validateValues(Map<?, ?> valueMaps,
GroupCoordinatorConfig g
throw new
InvalidConfigurationException(SHARE_SESSION_TIMEOUT_MS_CONFIG + " must be
greater than " +
SHARE_HEARTBEAT_INTERVAL_MS_CONFIG);
}
+ if
(ShareGroupAutoOffsetReset.valueOf(shareAutoOffsetReset.toUpperCase(Locale.ROOT))
== ShareGroupAutoOffsetReset.NONE) {
+ throw new
InvalidConfigurationException(SHARE_AUTO_OFFSET_RESET_CONFIG + " must be " +
+ ShareGroupAutoOffsetReset.LATEST + " or " +
ShareGroupAutoOffsetReset.EARLIEST);
+ }
+ if
(ShareGroupAutoOffsetReset.valueOf(shareAutoOffsetReset.toUpperCase(Locale.ROOT))
!= ShareGroupAutoOffsetReset.LATEST &&
+
ShareGroupAutoOffsetReset.valueOf(shareAutoOffsetReset.toUpperCase(Locale.ROOT))
!= ShareGroupAutoOffsetReset.EARLIEST) {
+ throw new
InvalidConfigurationException(SHARE_AUTO_OFFSET_RESET_CONFIG + " must be " +
+ ShareGroupAutoOffsetReset.LATEST + " or " +
ShareGroupAutoOffsetReset.EARLIEST);
+ }
Review Comment:
Thanks for the review. Yes you are right, I will remove this in the next
commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
