CalvinConfluent commented on code in PR #17619:
URL: https://github.com/apache/kafka/pull/17619#discussion_r1828046450
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2431,8 +2431,12 @@ class KafkaApis(val requestChannel: RequestChannel,
}
val markerResults = new ConcurrentHashMap[TopicPartition, Errors]()
- def maybeComplete(): Unit = {
- if (partitionsWithCompatibleMessageFormat.size ==
markerResults.size) {
+ val numPartitions = new
AtomicInteger(partitionsWithCompatibleMessageFormat.size)
Review Comment:
That is correct. It is common if the new coordinator returns an error for
the partition(NOT_LEADER_OR_FOLLOWER) fast enough to get ahead of the callback
of the replicaManager#appendRecords
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
