[
https://issues.apache.org/jira/browse/KAFKA-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895467#comment-17895467
]
Matthias J. Sax commented on KAFKA-17584:
-----------------------------------------
Thanks. I tried to cherry-pick to 3.7 branch, but it does not cherry-pick
cleanly. Should we include it in 3.7.2? If yes, would be great to get some help
from people who know this code better. I am also fine with just leave it as is,
and not include in 3.7.2. Thoughts?
> Fix incorrect synonym handling for dynamic log configurations
> -------------------------------------------------------------
>
> Key: KAFKA-17584
> URL: https://issues.apache.org/jira/browse/KAFKA-17584
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Christo Lolov
> Assignee: Christo Lolov
> Priority: Blocker
> Fix For: 3.9.0, 3.8.1
>
>
> Updating certain dynamic configurations (for example `message.max.bytes`)
> causes retention based on time to reset to the default value (source code)
> for log.retention.ms. This poses a durability issue if users have set their
> retention by using log.retention.hours or log.retention.minutes. In other
> words, if a user has set log.retention.hours=-1 (infinite retention) and they
> dynamically change `message.max.bytes` their retention will immediately
> change back to the default of 604800000 ms (7 days) and data before this will
> be scheduled for deletion immediately.
> Steps to reproduce:
> 1. Add log.retention.minutes=1,log.retention.check.interval.ms=1000 to
> server.properties
> 2. Start a single ZK or KRaft instance + a single Kafka instance
> 3. Create a topic using
> {code:java}
> bin/kafka-topics.sh --bootstrap-server localhost:9092 --create --topic A
> --replication-factor 1 --partitions 1 --config min.insync.replicas=1 --config
> segment.bytes=512{code}
> 4. Create a few segments with the console producer
> 5. Observe that they are deleted after 1 minute
> 6. Use the following command
> {code:java}
> bin/kafka-configs.sh --bootstrap-server loclahost:9092 --entity-type brokers
> --entity-default --alter --add-config message.max.bytes=1048609{code}
> (the value of `message.max.bytes` is irrelevant)
> 7. Create a few more segments with the console producer
> 8. Observe that segments are no longer deleted after 1 minute
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
