cmccabe commented on code in PR #17689:
URL: https://github.com/apache/kafka/pull/17689#discussion_r1829999576


##########
tests/kafkatest/tests/connect/connect_test.py:
##########
@@ -98,8 +95,6 @@ def test_file_source_and_sink(self, 
converter="org.apache.kafka.connect.json.Jso
         self.consumer_validator = ConsoleConsumer(self.test_context, 1, 
self.kafka, self.TOPIC_TEST,
                                                   consumer_timeout_ms=10000)
 
-        if self.zk:

Review Comment:
   Do we need this for the cases where ZK remains? (i.e. the Kafka 2.1 case?)
   
   or do we not test that here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to