jolshan commented on code in PR #17698: URL: https://github.com/apache/kafka/pull/17698#discussion_r1830007288
########## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ########## @@ -85,7 +105,7 @@ class AddPartitionsToTxnManager( private val verificationFailureRate = metricsGroup.newMeter(VerificationFailureRateMetricName, "failures", TimeUnit.SECONDS) private val verificationTimeMs = metricsGroup.newHistogram(VerificationTimeMsMetricName) - def verifyTransaction( + def addOrVerifyTransaction( Review Comment: Previously we were hitting errors on the boundaries of transactions because there weren't the same checks on the client side. Are all of those resolved with the existing epoch checks? Do we return retriable vs. fatal errors at the right times? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
