lianetm commented on code in PR #17694:
URL: https://github.com/apache/kafka/pull/17694#discussion_r1831229737
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorShardTest.java:
##########
@@ -1272,4 +1275,67 @@ public void
testReplayShareGroupMemberMetadataWithNullValue() {
verify(groupMetadataManager, times(1)).replay(key, null);
}
+
+ @Test
+ public void testReplayConsumerGroupRegularExpression() {
+ GroupMetadataManager groupMetadataManager =
mock(GroupMetadataManager.class);
+ OffsetMetadataManager offsetMetadataManager =
mock(OffsetMetadataManager.class);
+ CoordinatorMetrics coordinatorMetrics = mock(CoordinatorMetrics.class);
+ CoordinatorMetricsShard metricsShard =
mock(CoordinatorMetricsShard.class);
+ GroupCoordinatorShard coordinator = new GroupCoordinatorShard(
+ new LogContext(),
+ groupMetadataManager,
+ offsetMetadataManager,
+ Time.SYSTEM,
+ new MockCoordinatorTimer<>(Time.SYSTEM),
+ mock(GroupCoordinatorConfig.class),
+ coordinatorMetrics,
+ metricsShard
+ );
+
+ ConsumerGroupRegularExpressionKey key = new
ConsumerGroupRegularExpressionKey()
+ .setGroupId("group")
+ .setRegularExpression("ab*");
+
+ ConsumerGroupRegularExpressionValue value = new
ConsumerGroupRegularExpressionValue()
+ .setTopics(Arrays.asList("abc", "abcd"))
+ .setVersion(10L)
+ .setTimestamp(12345L);
+
+ coordinator.replay(0L, RecordBatch.NO_PRODUCER_ID,
RecordBatch.NO_PRODUCER_EPOCH, new CoordinatorRecord(
+ new ApiMessageAndVersion(key, (short) 15),
+ new ApiMessageAndVersion(value, (short) 0)
+ ));
+
+ verify(groupMetadataManager, times(1)).replay(key, value);
+ }
+
+ @Test
+ public void testReplayConsumerGroupRegularExpressionTombestone() {
Review Comment:
```suggestion
public void testReplayConsumerGroupRegularExpressionTombstone() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
