bbejeck commented on code in PR #17716:
URL: https://github.com/apache/kafka/pull/17716#discussion_r1833390332
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##########
@@ -1752,7 +1752,18 @@ public void
shouldCloseStateManagerEvenDuringFailureOnUncleanTaskClose() {
}
@Test
- public void shouldReturnOffsetsForRepartitionTopicsForPurging() {
+ public void shouldReturnCommittedOffsetsForRepartitionTopicsForPurging() {
+ final Map<TopicPartition, Long> purgeableOffsets =
doReturnPurgeableOffsets(true);
+ assertThat(purgeableOffsets, equalTo(singletonMap(new
TopicPartition("repartition", 1), 10L)));
+ }
+
+ @Test
+ public void
shouldReturnEmptyMapWhenNoCommitForRepartitionTopicsForPurging() {
+ final Map<TopicPartition, Long> purgeableOffsets =
doReturnPurgeableOffsets(false);
+ assertThat(purgeableOffsets, equalTo(Collections.emptyMap()));
+ }
Review Comment:
Needed to do this to re-use code as Junit4 doesn't have `@Parameterized` at
the test level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
