[
https://issues.apache.org/jira/browse/KAFKA-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660825#comment-16660825
]
ASF GitHub Bot commented on KAFKA-7532:
---------------------------------------
stanislavkozlovski opened a new pull request #5831: KAFKA-7532: Fix controller
log for list of shutting down brokers
URL: https://github.com/apache/kafka/pull/5831
As reported in
[KAFKA-7532](https://issues.apache.org/jira/browse/KAFKA-7532) - this line
prints out ```[2018-10-23 12:19:59,977] INFO [Controller id=0] Removed
ArrayBuffer() from list of shutting down brokers.
(kafka.controller.KafkaController)
```
This change seems to be present in all versions even as back as `0.9.0`. I
think it might be worth it to merge to `1.0` (pre-2.0 uses `"".format()`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Missing stringification in error message "Removed ArrayBuffer() from list of
> shutting down brokers. (kafka.controller.KafkaController)"
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-7532
> URL: https://issues.apache.org/jira/browse/KAFKA-7532
> Project: Kafka
> Issue Type: Bug
> Components: controller
> Affects Versions: 2.0.0
> Reporter: Andreas Kohn
> Assignee: Stanislav Kozlovski
> Priority: Minor
>
> Messages I saw in my logs:
> {noformat}
> [2018-10-23 12:19:59,975] INFO [RequestSendThread controllerId=0] Shutting
> down (kafka.controller.RequestSendThread)
> [2018-10-23 12:19:59,975] INFO [RequestSendThread controllerId=0] Stopped
> (kafka.controller.RequestSendThread)
> [2018-10-23 12:19:59,975] INFO [RequestSendThread controllerId=0] Shutdown
> completed (kafka.controller.RequestSendThread)
> [2018-10-23 12:19:59,977] INFO [Controller id=0] Broker failure callback for
> 1 (kafka.controller.KafkaController)
> [2018-10-23 12:19:59,977] INFO [Controller id=0] Removed ArrayBuffer() from
> list of shutting down brokers. (kafka.controller.KafkaController){noformat}
> Looking at
> https://github.com/apache/kafka/blob/a947fe8da8646058335ff76b9a744462a3337a63/core/src/main/scala/kafka/controller/KafkaController.scala#L414
> I'd guess there's a {{deadBrokersThatWereShuttingDown.mkString(",")}}
> missing, but my Scala-foo is too weak.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
