apoorvmittal10 commented on code in PR #17709:
URL: https://github.com/apache/kafka/pull/17709#discussion_r1834133327
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -507,19 +506,18 @@ public void acknowledgeSessionUpdate(String groupId,
ShareRequestMetadata reqMet
* but as we cannot determine which share partition errored out, we might
remove all the share partitions
* in the request.
*
- * @param groupId The group id in the share fetch request.
+ * @param shareFetch The share fetch request.
* @param topicIdPartitions The topic-partitions in the replica read
request.
- * @param future The future to complete with the exception.
* @param throwable The exception that occurred while fetching messages.
*/
public void handleFetchException(
- String groupId,
+ ShareFetch shareFetch,
Review Comment:
Yeah but then we have to make `handleFencedSharePartitionException` as
public. I was thinking to keep this public API and rest as internal to
SharePartitionManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
