AndrewJSchofield commented on code in PR #17739:
URL: https://github.com/apache/kafka/pull/17739#discussion_r1835733808
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -90,14 +90,17 @@ public void onExpiration() {
*/
@Override
public void onComplete() {
+ // We are utilizing lock so that onComplete doesn't do a dirty read
for global variables -
+ // partitionsAcquired and partitionsAlreadyFetched, since these
variables can get updated in a different tryComplete thread.
+ lock.lock();
log.trace("Completing the delayed share fetch request for group {},
member {}, "
+ "topic partitions {}", shareFetchData.groupId(),
shareFetchData.memberId(),
partitionsAcquired.keySet());
if (shareFetchData.future().isDone())
return;
Review Comment:
Hmm. Isn't this a return without unlocking? Seems wrong. I wonder if you
should rearrange the code here so there's a try-finally and it's not possible
to exit the method without unlocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
