cadonna commented on code in PR #17714:
URL: https://github.com/apache/kafka/pull/17714#discussion_r1836149437
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -369,10 +369,15 @@ public static StreamThread create(final TopologyMetadata
topologyMetadata,
final Runnable shutdownErrorHook,
final BiConsumer<Throwable, Boolean>
streamsUncaughtExceptionHandler) {
+ final boolean stateUpdaterEnabled =
InternalConfig.stateUpdaterEnabled(config.originals());
+
final String threadId = clientId + THREAD_ID_SUBSTRING + threadIdx;
+ final String stateUpdaterId = threadId.replace(THREAD_ID_SUBSTRING,
STATE_UPDATER_ID_SUBSTRING);
+ final String effectiveThreadId = stateUpdaterEnabled ? stateUpdaterId
: threadId;
Review Comment:
Could you please rename this variable to `restorationThreadId`?
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -369,10 +369,15 @@ public static StreamThread create(final TopologyMetadata
topologyMetadata,
final Runnable shutdownErrorHook,
final BiConsumer<Throwable, Boolean>
streamsUncaughtExceptionHandler) {
+ final boolean stateUpdaterEnabled =
InternalConfig.stateUpdaterEnabled(config.originals());
+
final String threadId = clientId + THREAD_ID_SUBSTRING + threadIdx;
+ final String stateUpdaterId = threadId.replace(THREAD_ID_SUBSTRING,
STATE_UPDATER_ID_SUBSTRING);
+ final String effectiveThreadId = stateUpdaterEnabled ? stateUpdaterId
: threadId;
final String logPrefix = String.format("stream-thread [%s] ",
threadId);
final LogContext logContext = new LogContext(logPrefix);
+ final LogContext effectiveLogContext = stateUpdaterEnabled ? new
LogContext(String.format("state-updater [%s] ", effectiveThreadId)): logContext
;
Review Comment:
Similarly, could you please rename this variable to `restorationLogContext`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
