[
https://issues.apache.org/jira/browse/KAFKA-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660868#comment-16660868
]
Sönke Liebau edited comment on KAFKA-7509 at 10/24/18 12:24 PM:
----------------------------------------------------------------
Hi [~rhauch], wouldn't this take away the ability to pass configuration options
to custom interceptor and partitioner classes?
This is probably not something that is widely done, but I can think of a few
use cases like making a call to an external system from a partitioner and
setting the target url in configuration. Or, come to think of it, the control
center interceptors also allow some configuration parameters to be passed to
them that are not defined in ProducerConfig I think.
Would it be an option to add prefixes to the config classes? Say anything
starting with authorizer.config. would be allowed, hence we can give people the
possibility of adding options in to pluggable classes but still be able to
properly validate the config to some extent.
was (Author: sliebau):
Hi [~rhauch], wouldn't this take away the ability to pass configuration options
to custom interceptor and partitioner classes?
This is probably not something that is widely done, but I can think of a few
use cases like making a call to an external system from a partitioner and
setting the target url in configuration. Or, come to think of it, the control
center interceptors also allow some configuration parameters to be passed to
them that are not defined in ProducerConfig I think.
> Kafka Connect logs unnecessary warnings about unused configurations
> -------------------------------------------------------------------
>
> Key: KAFKA-7509
> URL: https://issues.apache.org/jira/browse/KAFKA-7509
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
> Affects Versions: 0.10.2.0
> Reporter: Randall Hauch
> Assignee: Randall Hauch
> Priority: Major
>
> When running Connect, the logs contain quite a few warnings about "The
> configuration '{}' was supplied but isn't a known config." This occurs when
> Connect creates producers, consumers, and admin clients, because the
> AbstractConfig is logging unused configuration properties upon construction.
> It's complicated by the fact that the Producer, Consumer, and AdminClient all
> create their own AbstractConfig instances within the constructor, so we can't
> even call its {{ignore(String key)}} method.
> See also KAFKA-6793 for a similar issue with Streams.
> There are no arguments in the Producer, Consumer, or AdminClient constructors
> to control whether the configs log these warnings, so a simpler workaround
> is to only pass those configuration properties to the Producer, Consumer, and
> AdminClient that the ProducerConfig, ConsumerConfig, and AdminClientConfig
> configdefs know about.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
