frankvicky commented on code in PR #17767:
URL: https://github.com/apache/kafka/pull/17767#discussion_r1837580027
##########
tools/src/test/java/org/apache/kafka/tools/ToolsTestUtils.java:
##########
@@ -58,7 +58,7 @@ public static String captureStandardErr(Runnable runnable) {
return captureStandardStream(true, runnable);
}
- private static String captureStandardStream(boolean isErr, Runnable
runnable) {
+ public static String captureStandardStream(boolean isErr, Runnable
runnable) {
Review Comment:
I don't think you need to expose this method, since every invoke of this
method, the parameter `isErr` is hardcoded.
You should use another two wrapper methods (`captureStandardErr` and
`captureStandardOut`) instead of direct invoking this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
