m1a2st commented on code in PR #17776:
URL: https://github.com/apache/kafka/pull/17776#discussion_r1837967153
##########
core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala:
##########
@@ -1039,10 +1026,9 @@ class AbstractFetcherThreadTest {
fetcher.verifyLastFetchedEpoch(partition, Some(5))
}
- @Test
- def testTruncateOnFetchDoesNotProcessPartitionData(): Unit = {
- assumeTrue(truncateOnFetch)
-
+ @ParameterizedTest
+ @ValueSource(booleans = Array(true))
+ def testTruncateOnFetchDoesNotProcessPartitionData(truncateOnFetch:
Boolean): Unit = {
Review Comment:
If there only test `true` condition, why we need to use `@ValueSource` ?
##########
core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala:
##########
@@ -540,9 +539,9 @@ class AbstractFetcherThreadTest {
assertEquals(2, replicaState.logEndOffset)
}
- @Test
- def testTruncationOnFetchSkippedIfPartitionRemoved(): Unit = {
- assumeTrue(truncateOnFetch)
+ @ParameterizedTest
+ @ValueSource(booleans = Array(true))
+ def testTruncationOnFetchSkippedIfPartitionRemoved(truncateOnFetch:
Boolean): Unit = {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
