FrankYang0529 commented on code in PR #17794:
URL: https://github.com/apache/kafka/pull/17794#discussion_r1840306519
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -2765,6 +2765,34 @@ public void
testDeleteRetentionMsBeingCancelledBeforeSecondDelete() throws Remot
verify(remoteStorageManager).deleteLogSegmentData(metadataList.get(1));
}
+ @Test
+ public void testDeleteRetentionMsBiggerThanTimeMs() throws
RemoteStorageException, ExecutionException, InterruptedException {
+ LogConfig mockLogConfig = new LogConfig(Map.of("retention.ms",
time.milliseconds() + 100));
Review Comment:
Yes, set it to 1 month after current epoch. Thanks for the suggestion 👍 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
