apoorvmittal10 commented on PR #17796: URL: https://github.com/apache/kafka/pull/17796#issuecomment-2474212658
Thanks @AndrewJSchofield for review and good points. > Can the partition become a leader after it has previously become a follower? I just wonder whether the state machine is more complicated than this PR implies? Yes, that can always happen. Once it does then next share fetch request should load the share partition. The scenario is not very different then partition being shuffled across brokers. The broker who is the leader of the partition should be able to load share partition. > The listener is called under a lock in the Partition. The listener implementation needs to be very careful not to do anything brave under that lock. I expect there is potential for a deadlock here. The lock is for each Partition, but I do get the point. I can make the call outside lock as well, I ll wait for @junrao's comments as he can help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
