divijvaidya commented on code in PR #17814:
URL: https://github.com/apache/kafka/pull/17814#discussion_r1842323044
##########
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##########
@@ -322,6 +325,7 @@ public void
testAcknowledgementCommitCallbackSuccessfulAcknowledgement(String pe
ProducerRecord<byte[], byte[]> record = new
ProducerRecord<>(tp.topic(), tp.partition(), null, "key".getBytes(),
"value".getBytes());
KafkaProducer<byte[], byte[]> producer = createProducer(new
ByteArraySerializer(), new ByteArraySerializer());
Review Comment:
should the closeable resources be closed in a try / finally block so that
the resources are closed even if we have an assertion failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
