ShivsundarR opened a new pull request, #17824:
URL: https://github.com/apache/kafka/pull/17824

   *What*
   There was a bug in handling piggyback acknowledgements in 
`ShareConsumeRequestManager`, where the `fetchAcknowledgementsMap` could be 
updated when the request was in flight and when the `ShareFetch` response is 
received, we were removing any acknowledgements(without actually sending them) 
which came when the request was in flight.
   
   *Fix*
   Now we are maintaining 2 separate maps(one which has the acknowledgements to 
send and one which keeps track of the acknowledgements in flight).
   
   *Testing*
   Added a unit test which passes after this fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to