lianetm commented on code in PR #17789:
URL: https://github.com/apache/kafka/pull/17789#discussion_r1843913989
##########
core/src/test/scala/integration/kafka/api/PlaintextConsumerPollTest.scala:
##########
@@ -32,6 +34,12 @@ import scala.jdk.CollectionConverters._
@Timeout(600)
class PlaintextConsumerPollTest extends AbstractConsumerTest {
+ override protected def brokerPropertyOverrides(properties: Properties): Unit
= {
+ super.brokerPropertyOverrides(properties)
+
properties.setProperty(GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG,
"1000")
Review Comment:
I notice there are several test in this same file overriding the equivalent
of this prop for the classic consumer
(ConsumerConfig.HEARTBEAT_INTERVAL_MS_CONFIG), but to 500. Should we consider
that value instead? With that, we would have those tests running for both
consumers with the same config. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
