pegasas commented on PR #17190: URL: https://github.com/apache/kafka/pull/17190#issuecomment-2481782417
> @pegasas -- I am still somewhat confused. Did you see my latest in-line tagging? > > * [KAFKA-12829: Remove deprecated Topology#addProcessor of old Processor API #17190 (comment)](https://github.com/apache/kafka/pull/17190#discussion_r1828530061) > * [KAFKA-12829: Remove deprecated Topology#addProcessor of old Processor API #17190 (comment)](https://github.com/apache/kafka/pull/17190#discussion_r1828530235) > * [KAFKA-12829: Remove deprecated Topology#addProcessor of old Processor API #17190 (comment)](https://github.com/apache/kafka/pull/17190#discussion_r1828530363) > * [KAFKA-12829: Remove deprecated Topology#addProcessor of old Processor API #17190 (comment)](https://github.com/apache/kafka/pull/17190#discussion_r1828530435) > > These are still open questions that I think we need to resolve before we can merge this PR. And AK 4.0 release deadline is approaching, so I would like to finish this :) Hi, @mjsax , as line318 shows, ``` driver = new TopologyTestDriver(createStatefulTopology(storeName), props); ``` which createStatefulTopology would be deprecated. https://github.com/apache/kafka/blob/trunk/streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java#L1571-L1578 It seems my comments are disappeared several times. it is weird. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
