CalvinConfluent commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1847487125
##########
core/src/test/scala/integration/kafka/api/TransactionsTest.scala:
##########
@@ -586,15 +589,20 @@ class TransactionsTest extends IntegrationTestHarness {
producer1.beginTransaction()
val result =
producer1.send(TestUtils.producerRecordWithExpectedTransactionStatus(topic1,
null, "1", "5", willBeCommitted = false))
val recordMetadata = result.get()
- error(s"Missed a producer fenced exception when writing to
${recordMetadata.topic}-${recordMetadata.partition}. Grab the logs!!")
+ error(s"Missed an exception when writing to
${recordMetadata.topic}-${recordMetadata.partition}. Grab the logs!!")
brokers.foreach { broker =>
error(s"log dirs:
${broker.logManager.liveLogDirs.map(_.getAbsolutePath).head}")
}
fail("Should not be able to send messages from a fenced producer.")
} catch {
- case _: ProducerFencedException =>
- case e: ExecutionException =>
- assertTrue(e.getCause.isInstanceOf[ProducerFencedException])
+ case _: InvalidProducerEpochException =>
+ case e: ExecutionException => {
+ if (quorum == "zk") {
Review Comment:
Updated the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
