mjsax commented on code in PR #17855:
URL: https://github.com/apache/kafka/pull/17855#discussion_r1847640621
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/WindowKeySchemaTest.java:
##########
@@ -126,7 +126,7 @@ interface TriFunction<A, B, C, R> {
private final Window window = new TimeWindow(startTime, endTime);
private final Windowed<String> windowedKey = new Windowed<>(key, window);
private KeySchema keySchema;
- private final Serde<Windowed<String>> keySerde = new
WindowedSerdes.TimeWindowedSerde<>(serde, Long.MAX_VALUE);
+ private final Serde<Windowed<String>> keySerde = new
WindowedSerdes.TimeWindowedSerde<>(serde, endTime - startTime);
Review Comment:
Fixing window size to avoid WARN logs during test run (same below)
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/WindowKeySchemaTest.java:
##########
@@ -126,7 +126,7 @@ interface TriFunction<A, B, C, R> {
private final Window window = new TimeWindow(startTime, endTime);
private final Windowed<String> windowedKey = new Windowed<>(key, window);
private KeySchema keySchema;
- private final Serde<Windowed<String>> keySerde = new
WindowedSerdes.TimeWindowedSerde<>(serde, Long.MAX_VALUE);
+ private final Serde<Windowed<String>> keySerde = new
WindowedSerdes.TimeWindowedSerde<>(serde, endTime - startTime);
Review Comment:
Fixing window size to avoid WARN logs during test run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
