cmccabe commented on code in PR #17867:
URL: https://github.com/apache/kafka/pull/17867#discussion_r1849116901
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1029,7 +1030,8 @@ TimelineHashSet<TopicIdPartition> imbalancedPartitions() {
}
boolean isElrEnabled() {
- return eligibleLeaderReplicasEnabled &&
featureControl.metadataVersion().isElrSupported();
+ return featureControl.metadataVersion().isElrSupported() &&
featureControl.finalizedFeatures(offsetControl.lastStableOffset()).
Review Comment:
I don't think this is correct. Why would we want isElrEnabled to be reading
from a point in the past? Surely we want to know whether elr is CURRENTLY
enabled, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
