jolshan commented on code in PR #17698:
URL: https://github.com/apache/kafka/pull/17698#discussion_r1848891260
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##########
@@ -922,6 +946,103 @@ public void testTransactionManagerEnablesV2() {
assertTrue(transactionManager.isTransactionV2Enabled());
}
+ @Test
+ public void testTransactionV2AddPartitionAndOffsets() throws
InterruptedException {
+ initializeTransactionManager(Optional.of(transactionalId), true);
+ doInitTransactions();
+
+ transactionManager.beginTransaction();
+
+ Future<RecordMetadata> responseFuture = appendToAccumulator(tp0);
+
+ assertFalse(responseFuture.isDone());
+
+ prepareProduceResponse(Errors.NONE, producerId, epoch);
+ assertTrue(transactionManager.transactionContainsPartition(tp0));
+ assertTrue(transactionManager.isSendToPartitionAllowed(tp0));
+ assertFalse(responseFuture.isDone());
+ runUntil(responseFuture::isDone);
+
+ // Now, test adding the offsets.
+ Map<TopicPartition, OffsetAndMetadata> offsets = new HashMap<>();
+ offsets.put(tp1, new OffsetAndMetadata(1));
+
+ TransactionalRequestResult addOffsetsResult =
transactionManager.sendOffsetsToTransaction(
+ offsets, new ConsumerGroupMetadata(consumerGroupId));
+
+ assertTrue(transactionManager.hasPendingOffsetCommits());
+
+ // the result doesn't complete until TxnOffsetCommit returns
Review Comment:
Interesting. I wonder if this could cause some weird behavior in the case
where we only try to send offset commits. We had a lot of discussion about what
happens if we don't know if we added a partition, but I guess here it is ok
since we have to go through two operations through the txn, 1 to add and 2 to
commit an offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
