kamalcph commented on code in PR #17859:
URL: https://github.com/apache/kafka/pull/17859#discussion_r1851419947
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -1167,6 +1167,22 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigurable w
throw new ConfigException(s"$errorMsg, value should be at least 1")
}
}
+
+ if
(RemoteLogManagerConfig.REMOTE_LOG_MANAGER_COPIER_THREAD_POOL_SIZE_PROP.equals(k)
||
+
RemoteLogManagerConfig.REMOTE_LOG_MANAGER_EXPIRATION_THREAD_POOL_SIZE_PROP.equals(k)
||
+ RemoteLogManagerConfig.REMOTE_LOG_READER_THREADS_PROP.equals(k)) {
+ val newValue = v.asInstanceOf[Int]
+ val oldValue = server.config.getInt(k)
+ if (newValue != oldValue) {
+ val errorMsg = s"Dynamic thread count update validation failed for
$k=$v"
+ if (newValue <= 0)
Review Comment:
Removed the validation for copier and expiration thread pool. It follows the
default validation set in ConfigDef (Value can be -1 or greater than 0). With
this, the static and dynamic validations are same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
