ableegoldman commented on code in PR #17906:
URL: https://github.com/apache/kafka/pull/17906#discussion_r1853236749


##########
docs/streams/upgrade-guide.html:
##########
@@ -1667,12 +1688,21 @@ <h3 class="anchor-heading"><a 
id="streams_api_broker_compat" class="anchor-link"
             <td></td>
             <td>compatible with exactly-once turned off<br>(requires broker 
version 0.11.0.x or higher);<br>requires message format 0.10 or 
higher;<br>message headers are not supported<br>(requires broker version 
0.11.0.x or higher<br>with message format 0.11 or higher)</td>
             <td>compatible; requires message format 0.10 or higher;<br>if 
message headers are used, message format 0.11<br>or higher required</td>
+            <td>compatible</td>
           </tr>
           <tr>
-            <td>2.2.1 and<br>2.3.x and<br>2.4.x and<br>2.5.x and<br>2.6.x 
and<br>2.7.x and<br>2.8.x and<br>3.0.x and<br>3.1.x and<br>3.2.x and<br>3.3.x 
and<br>3.4.x and<br>3.5.x and<br>3.6.x and<br>3.7.x</td>
+            <td>2.2.1 and<br>2.3.x and<br>2.4.x and<br>2.5.x and<br>2.6.x 
and<br>2.7.x and<br>2.8.x and<br>3.0.x and<br>3.1.x and<br>3.2.x and<br>3.3.x 
and<br>3.4.x and<br>3.5.x and<br>3.6.x and<br>3.7.x and<br>3.8.x 
and<br>3.9.x</td>
             <td></td>
             <td></td>
             <td>compatible; requires message format 0.11 or 
higher;<br>enabling exactly-once v2 requires 2.4.x or higher</td>

Review Comment:
   @mjsax is this right? I always thought eosv2 needed brokers to be 2.5 or 
higher, not 2.4. Am I misremembering this or is the matrix wrong?
   
   This error message could also be wrong I suppose but this log in 
StreamThread at least seems to agree it's 2.5:
   
   ```
   log.error("Shutting down because the Kafka cluster seems to be on a too old 
version. " +
                                 "Setting {}=\"{}\" requires broker version 2.5 
or higher.",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to