m1a2st commented on code in PR #17440:
URL: https://github.com/apache/kafka/pull/17440#discussion_r1860573841
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CheckAndUpdatePositionsEvent.java:
##########
@@ -32,4 +32,8 @@ public class CheckAndUpdatePositionsEvent extends
CompletableApplicationEvent<Bo
public CheckAndUpdatePositionsEvent(long deadlineMs) {
super(Type.CHECK_AND_UPDATE_POSITIONS, deadlineMs);
}
+
+ public CheckAndUpdatePositionsEvent(long deadlineMs, boolean
isPassedByErrorEvent) {
+ super(Type.CHECK_AND_UPDATE_POSITIONS, deadlineMs,
isPassedByErrorEvent);
+ }
Review Comment:
For me, a `CompletableApplicationEvent` is an event that needs to be handled
by the application thread. The application thread has two options for
processing such events: `processBackgroundEvent` and `addAndGet`. Therefore,
every event should have this parameter. However, currently, only the
`CheckAndUpdatePositionsEvent` uses it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
