TaiJuWu commented on code in PR #17954:
URL: https://github.com/apache/kafka/pull/17954#discussion_r1860502292
##########
core/src/test/scala/unit/kafka/coordinator/group/CoordinatorLoaderImplTest.scala:
##########
@@ -312,7 +312,8 @@ class CoordinatorLoaderImplTest {
.thenThrow(new RuntimeException("Error!"))
val ex = assertFutureThrows(loader.load(tp, coordinator),
classOf[RuntimeException])
- assertEquals("Error!", ex.getMessage)
+
Review Comment:
fix CoordinatorLoaderImplTest > testDeserializationErrorFailsTheLoading()
author: @frankvicky
##########
core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala:
##########
@@ -74,6 +75,8 @@ class SaslClientsWithInvalidCredentialsTest extends
AbstractSaslTest {
override def setUp(testInfo: TestInfo): Unit = {
startSasl(jaasSections(kafkaServerSaslMechanisms,
Some(kafkaClientSaslMechanism), Both,
JaasTestUtils.KAFKA_SERVER_CONTEXT_NAME))
+ val superuserLoginContext = jaasAdminLoginModule(kafkaClientSaslMechanism)
Review Comment:
Fix `SaslClientsWithInvalidCredentialsTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
