AndrewJSchofield commented on code in PR #17775:
URL: https://github.com/apache/kafka/pull/17775#discussion_r1863265749
##########
clients/src/main/java/org/apache/kafka/clients/admin/ForwardingAdmin.java:
##########
@@ -304,6 +304,12 @@ public DescribeShareGroupsResult
describeShareGroups(Collection<String> groupIds
return delegate.describeShareGroups(groupIds, options);
}
+ @Override
+ public ListShareGroupOffsetsResult listShareGroupOffsets(Map<String,
ListShareGroupOffsetsSpec> groupSpecs,
+
ListShareGroupOffsetsOptions options) {
Review Comment:
nit: Slightly scruffy indentation compared with the rest of this file.
##########
checkstyle/checkstyle.xml:
##########
@@ -123,7 +123,7 @@
</module>
<module name="ClassDataAbstractionCoupling">
<!-- default is 7 -->
- <property name="max" value="25"/>
+ <property name="max" value="30"/>
Review Comment:
This seems like a surprising side-effect of this PR. I don't think you
should change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
