m1a2st commented on PR #17440: URL: https://github.com/apache/kafka/pull/17440#issuecomment-2508852749
> One suggestion already: we can simplifying the tweak we had to introduce on the unsubscribe to ignore metadata errors (with your PR, they won't pop out unexpectedly), so I would say we can remove InvalidTopic and TopicAuth from here (leaving GroupAuth only) I think we should focus on `PlaintextConsumerSubscriptionTest#testSubscribeInvalidTopicCanUnsubscribe` this test, In CONSUMER protocol, we will throw `InvalidTopicException` on `unsubscribe`, If we don't want this behaviour, we also need to use other way to sallow this metadata error, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
