dejan2609 commented on code in PR #10967:
URL: https://github.com/apache/kafka/pull/10967#discussion_r1864919496
##########
build.gradle:
##########
@@ -143,6 +143,9 @@ ext {
libs.junitPlatformLanucher,
project(":test-common:test-common-runtime")
]
+
+ // See README.md for this build option details and example of usage
+ checkstyleVersion = project.hasProperty('checkstyleVersion') ?
checkstyleVersion : versions.checkstyle
Review Comment:
Hi @chia7712 and thanks for stopping by ! Please allow me to add some more
details below.
_**Prologue**_ (relevant comment by @romani from CheksTyle team):
https://github.com/apache/kafka/pull/10656#issuecomment-835809154
This (now fairly dusty) PR was created in order to provide CheckStyle team
with some handy way to include Kafka project into CheckStyle regression suite.
As time went by PR slipped through the cracks (but I decided to stick with it
and hence we are having a discussion now :smiley:).
So, if this PR gets into Kafka trunk CheckStyle team will be able to perform
following sequence on their end, i.e. on their CI server (note: **_X.yz_**
stands for any specific CheckStyle version):
```
git clone
git checkout trunk
./gradlew check -PcheckstyleVersion=X.yz
```
As for a place where this change should reside
([dependencies.gradle](https://github.com/apache/kafka/blob/trunk/gradle/dependencies.gradle#L25)
vs. [common build
options](https://github.com/apache/kafka/blob/trunk/README.md#common-build-options))
I am open for a discussion.
Current proposal is aligned with suggestion made by @ijuma here:
https://github.com/apache/kafka/pull/10656#issuecomment-836074067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
