peterxcli commented on code in PR #17991:
URL: https://github.com/apache/kafka/pull/17991#discussion_r1865325818


##########
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##########
@@ -563,7 +563,7 @@ public static <T extends Throwable> void assertFutureThrows(
         String expectedMessage
     ) {
         T receivedException = assertFutureThrows(future, 
expectedCauseClassApiException);
-        assertEquals(expectedMessage, receivedException.getMessage());
+        assertTrue(receivedException.getMessage().contains(expectedMessage));

Review Comment:
   Do you mean `public static <T extends Throwable> T 
assertFutureThrows(Future<?> future, Class<T> exceptionCauseClass)` and 
`assertFutureThrows(Future<?> future, Class<T> expectedCauseClassApiException, 
String expectedMessage)` are duplicate?
   
   I think both overload has their references, so I guess you are referring to 
another package or file which define same util method?
   If I miss something, please tell me. Thanks! @chia7712 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to