dajac commented on code in PR #17989:
URL: https://github.com/apache/kafka/pull/17989#discussion_r1868097845
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java:
##########
@@ -313,12 +315,32 @@ private void onFailure(final Throwable exception, final
long responseTimeMs) {
logger.debug(message);
} else {
logger.error("{} failed due to fatal error: {}",
heartbeatRequestName(), exception.getMessage());
- handleFatalFailure(exception);
+ if (isHBApiUnsupportedErrorMsg(exception)) {
+ // This is expected to be the case where building the request
fails because the node does not support
+ // the API. Propagate custom message.
+ String msg = "The cluster does not support the new consumer
group protocol. " +
Review Comment:
Should we use the same error message here? We could perhaps have it in a
constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
