dajac commented on code in PR #17976:
URL: https://github.com/apache/kafka/pull/17976#discussion_r1869058336
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -3224,6 +3228,59 @@ private void replaceMember(
));
}
+ /**
+ * Maybe delete the resolved regular expression associated to the provided
member if
+ * it was the last subscribed member to it.
+ *
+ * @param records The record accumulator.
+ * @param group The group.
+ * @param member The member removed from the group.
+ */
+ private void maybeDeleteResolvedRegularExpression(
Review Comment:
i considered calling `maybeDeleteResolvedRegularExpressions` from this one
but i found that building a Map and a Set was not necessary so i opted for
keeping a slightly more efficient implementation here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
