lucasbru commented on code in PR #18033:
URL: https://github.com/apache/kafka/pull/18033#discussion_r1869244623
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -841,6 +841,8 @@ public class StreamsConfig extends AbstractConfig {
public static final String
WINDOW_STORE_CHANGE_LOG_ADDITIONAL_RETENTION_MS_CONFIG =
"windowstore.changelog.additional.retention.ms";
private static final String
WINDOW_STORE_CHANGE_LOG_ADDITIONAL_RETENTION_MS_DOC = "Added to a windows
maintainMs to ensure data is not deleted from the log prematurely. Allows for
clock drift. Default is 1 day";
+ private static final String[] NOT_CONFIGURABLE_IN_GLOBAL_CONSUMER =
+ new String[] {ConsumerConfig.GROUP_PROTOCOL_CONFIG};
Review Comment:
It changes the meaning. as far as I understand this class, common consumer
config are defined in `consumer.group.protocol`, but what we are ignoring is
just `group.protocol`. So I think this would be incorrect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
