AndrewJSchofield commented on code in PR #18029:
URL: https://github.com/apache/kafka/pull/18029#discussion_r1869265407
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java:
##########
@@ -1122,6 +1156,18 @@ public void testUnknownTopicIdError() {
assertEquals(0L, metadata.timeToNextUpdate(time.milliseconds()));
}
+ @Test
+ public void testDisconnectExceptionOnShareAcknowledge() {
+ buildRequestManager();
+ assignFromSubscribed(singleton(tp0));
+
+ assertEquals(1, sendFetches());
+ client.prepareResponse(fullFetchResponse(tip0, records,
acquiredRecords, Errors.NONE));
+
Review Comment:
This doesn't look entirely finished. Either you're missing some additional
test code that you omitted, or you've left a bunch of blank lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
