smjn commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1869313717
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##########
@@ -240,9 +249,43 @@ public void startup(
log.info("Starting up.");
numPartitions = shareGroupTopicPartitionCount.getAsInt();
+ setupRecordPruning();
log.info("Startup complete.");
}
+ private void setupRecordPruning() {
+ timer.add(new TimerTask(config.shareCoordinatorTopicPruneIntervalMs())
{
+ @Override
+ public void run() {
+ for (int i = 0; i < numPartitions; i++) {
Review Comment:
@dajac we don't need the coordinators, but the list of topic partitions
whose coordinators are ACTIVE at the point of execution of the timer job.
CoordinatorRuntime
```
public List<TopicPartition> activeTopicPartitions() {
return coordinators.entrySet().stream()
.filter(entry ->
entry.getValue().state.equals(CoordinatorState.ACTIVE))
.map(Map.Entry::getKey)
.toList();
}
```
Caller:
```
activeTopicPartitions.forEach(tp -> runtime.scheudle(tp, ...)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
