bbejeck commented on code in PR #18043:
URL: https://github.com/apache/kafka/pull/18043#discussion_r1870258964


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java:
##########
@@ -251,7 +249,7 @@ public String stateAsString(long committedOffset) {
     public ListGroupsResponseData.ListedGroup asListedGroup(long 
committedOffset) {
         return new ListGroupsResponseData.ListedGroup()
             .setGroupId(groupId)
-            .setProtocolType(ConsumerProtocol.PROTOCOL_TYPE)
+            .setProtocolType("streams")

Review Comment:
   This is fine, but do we want to consider an `enum` for streams related 
requests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to