dajac commented on code in PR #18020: URL: https://github.com/apache/kafka/pull/18020#discussion_r1870873476
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroup.java: ########## @@ -798,6 +827,60 @@ private void validateMemberEpoch( } } + /** + * Computes the subscription type based on the provided information. + * + * @param subscribedRegularExpressions The subscribed regular expression count. + * @param subscribedTopicNames The subscribed topic name count. + * @param numberOfMembers The number of members in the group. + * + * @return The subscription type. + */ + public static SubscriptionType subscriptionType( Review Comment: This is the core change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org