AndrewJSchofield commented on code in PR #18060:
URL: https://github.com/apache/kafka/pull/18060#discussion_r1871512760
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -8674,7 +8674,8 @@ public void testConsumerGroupDescribeWithErrors() {
List<ConsumerGroupDescribeResponseData.DescribedGroup> actual =
context.sendConsumerGroupDescribe(List.of(groupId));
ConsumerGroupDescribeResponseData.DescribedGroup describedGroup = new
ConsumerGroupDescribeResponseData.DescribedGroup()
.setGroupId(groupId)
- .setErrorCode(Errors.GROUP_ID_NOT_FOUND.code());
+ .setErrorCode(Errors.GROUP_ID_NOT_FOUND.code())
+ .setErrorMessage("Group groupId not found.");
Review Comment:
Also in #17706
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -521,6 +521,7 @@ public
List<ConsumerGroupDescribeResponseData.DescribedGroup> consumerGroupDescr
describedGroups.add(new
ConsumerGroupDescribeResponseData.DescribedGroup()
.setGroupId(groupId)
.setErrorCode(Errors.GROUP_ID_NOT_FOUND.code())
+ .setErrorMessage(exception.getMessage())
Review Comment:
This line is included in #17706 I believe.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -14951,6 +14953,7 @@ public void testConsumerGroupDescribeOnShareGroup() {
new ConsumerGroupDescribeResponseData.DescribedGroup()
.setGroupId(groupId)
.setErrorCode(Errors.GROUP_ID_NOT_FOUND.code())
+ .setErrorMessage("Group group-foo is not a consumer group")
Review Comment:
And this one.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -8716,7 +8717,8 @@ public void
testConsumerGroupDescribeBeforeAndAfterCommittingOffset() {
List<ConsumerGroupDescribeResponseData.DescribedGroup> actual =
context.groupMetadataManager.consumerGroupDescribe(List.of(consumerGroupId),
context.lastCommittedOffset);
ConsumerGroupDescribeResponseData.DescribedGroup describedGroup = new
ConsumerGroupDescribeResponseData.DescribedGroup()
.setGroupId(consumerGroupId)
- .setErrorCode(Errors.GROUP_ID_NOT_FOUND.code());
+ .setErrorCode(Errors.GROUP_ID_NOT_FOUND.code())
+ .setErrorMessage("Group consumerGroupId not found.");
Review Comment:
And this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
