AndrewJSchofield commented on code in PR #18053:
URL: https://github.com/apache/kafka/pull/18053#discussion_r1871597746
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -371,30 +372,52 @@ public static RecordState forId(byte id) {
public CompletableFuture<Void> maybeInitialize() {
log.debug("Maybe initialize share partition: {}-{}", groupId,
topicIdPartition);
CompletableFuture<Void> future = new CompletableFuture<>();
+ AtomicReference<Optional<Throwable>> futureException = new
AtomicReference<>(Optional.empty());
// Check if the share partition is already initialized.
- maybeCompleteInitialization(future);
- if (future.isDone()) {
+ InitializationResult initializationResult =
maybeCompleteInitialization();
+ if (initializationResult.isComplete()) {
+ if (initializationResult.throwable() != null) {
+ future.completeExceptionally(initializationResult.throwable());
+ } else {
+ future.complete(null);
+ }
return future;
}
// All the pending requests should wait to get completed before the
share partition is initialized.
// Attain lock to avoid any concurrent requests to be processed.
lock.writeLock().lock();
+ boolean shouldFutureBeCompleted = false;
try {
// Re-check the state to verify if previous requests has already
initialized the share partition.
- maybeCompleteInitialization(future);
- if (future.isDone()) {
+ initializationResult = maybeCompleteInitialization();
+ if (initializationResult.isComplete()) {
+ if (initializationResult.throwable() != null) {
+
futureException.set(Optional.of(initializationResult.throwable()));
+ } else {
+ futureException.set(Optional.empty());
Review Comment:
That is its initial value, so you don't need to set the exception here.
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1142,34 +1176,29 @@ private boolean stateNotActive() {
return partitionState() != SharePartitionState.ACTIVE;
}
- private void completeInitializationWithException(CompletableFuture<Void>
future, Throwable exception) {
+ private void completeInitializationWithException() {
lock.writeLock().lock();
try {
partitionState = SharePartitionState.FAILED;
} finally {
lock.writeLock().unlock();
}
- future.completeExceptionally(exception);
}
- private void maybeCompleteInitialization(CompletableFuture<Void> future) {
+ private InitializationResult maybeCompleteInitialization() {
Review Comment:
I think I'd call it `checkInitializationCompletion`. This method does not
complete initialization at all. It tell you whether it's complete or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
