bbejeck commented on code in PR #18069:
URL: https://github.com/apache/kafka/pull/18069#discussion_r1872205416


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1701,7 +1720,6 @@ private void throwIfStreamsGroupHeartbeatRequestIsInvalid(
             }
             // TODO: check that active, standby and warmup do not intersect
         } else if (request.memberEpoch() == LEAVE_GROUP_STATIC_MEMBER_EPOCH) {
-            throwIfEmptyString(request.memberId(), "MemberId can't be empty.");

Review Comment:
   Don't need this here anymore since we first check if `memberId` is null or 
empty before reaching the if/else statements



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to