KApolinario1120 commented on code in PR #17973:
URL: https://github.com/apache/kafka/pull/17973#discussion_r1872312306


##########
streams/src/main/java/org/apache/kafka/streams/AutoOffsetReset.java:
##########
@@ -0,0 +1,76 @@
+package org.apache.kafka.streams;
+
+import java.time.Duration;
+import java.util.Optional;
+
+/**
+ * Sets the {@code auto.offset.reset} configuration when
+ * {@link #addSource(AutoOffsetReset, String, String...) adding a source 
processor} or when creating {@link KStream}
+ * or {@link KTable} via {@link StreamsBuilder}.
+ */
+public class AutoOffsetReset {
+    protected final Optional<Long> duration;
+
+    protected AutoOffsetReset(Optional<Long> duration) {
+        this.duration = duration;
+    }
+
+    /**
+     * Creates an AutoOffsetReset instance representing "latest".
+     * 
+     * @return an AutoOffsetReset instance for the "latest" offset.
+     */
+    public static AutoOffsetReset latest() {
+        return new AutoOffsetReset(Optional.empty());
+    }
+
+    /**
+     * Creates an AutoOffsetReset instance representing "earliest".
+     * 
+     * @return an AutoOffsetReset instance for the "earliest" offset.
+     */
+    public static AutoOffsetReset earliest() {
+        return new AutoOffsetReset(Optional.of(0L));
+    }
+
+    /**
+     * Creates an AutoOffsetReset instance with a custom duration.
+     * 
+     * @param duration the duration to use for the offset reset; must be 
non-negative.
+     * @return an AutoOffsetReset instance with the specified duration.
+     * @throws IllegalArgumentException if the duration is negative.
+     */
+    public static AutoOffsetReset duration(Duration duration) {

Review Comment:
   Done, I know discussion around this one point has shifted around a few times 
so I will change again if needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to