cadonna commented on code in PR #18066:
URL: https://github.com/apache/kafka/pull/18066#discussion_r1872737109


##########
README.md:
##########
@@ -1,5 +1,14 @@
-Apache Kafka
-=================
+# Apache Kafka
+
+<a href="https://kafka.apache.org/";>
+<picture>
+  <source media="(prefers-color-scheme: dark)" 
srcset="docs/images/kafka-logo-readme-dark.svg">
+  <source media="(prefers-color-scheme: light)" 
srcset="docs/images/kafka-logo-readme-light.svg">
+  <img alt="Kafka Logo" src="docs/images/kafka-logo-readme-light.svg" 
width="80"> 
+</picture>
+</a>
+<br><br>

Review Comment:
   @swikarpat Is it possible to put the logo in front of "Apache Kafka" on line 
number 1 so that it is shown in the title? 
   In general I find it a good a idea to put the logo in the title of the 
README. However, the logo should take up too much space. Thus, the logo should 
be smaller and be incorporated in the title, in my opinion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to