snehashisp commented on code in PR #17741: URL: https://github.com/apache/kafka/pull/17741#discussion_r1873332310
########## connect/runtime/src/main/java/org/apache/kafka/connect/util/PluginVersionUtils.java: ########## @@ -0,0 +1,186 @@ +package org.apache.kafka.connect.util; + +import org.apache.kafka.common.config.ConfigDef; +import org.apache.kafka.common.config.ConfigException; +import org.apache.kafka.connect.connector.Connector; +import org.apache.kafka.connect.runtime.ConnectorConfig; +import org.apache.kafka.connect.runtime.isolation.PluginDesc; +import org.apache.kafka.connect.runtime.isolation.Plugins; +import org.apache.kafka.connect.runtime.rest.entities.ConnectorType; +import org.apache.maven.artifact.versioning.InvalidVersionSpecificationException; +import org.apache.maven.artifact.versioning.VersionRange; + +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.function.Function; +import java.util.function.Supplier; +import java.util.stream.Collectors; + +public class PluginVersionUtils { + + private static Plugins plugins = null; Review Comment: Thanks for catching this. I created a new `PluginsRecommender` class that is instantiated from a `plugins` instance so that we can avoid this problem. This also partially addresses your previous comment https://github.com/apache/kafka/pull/16984#discussion_r1868500756 and reduces most of the new exposed methods from plugins instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org