ShivsundarR commented on code in PR #18063:
URL: https://github.com/apache/kafka/pull/18063#discussion_r1875353133
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -990,16 +990,18 @@ UnsentRequest buildRequest() {
}
ShareAcknowledgeRequest.Builder requestBuilder =
sessionHandler.newShareAcknowledgeBuilder(groupId, fetchConfig);
Review Comment:
Yeah, right. The handler does not clear the acknowledgements which can be a
problem when future requests are built. I have added code to clear the
`nextPartitions` and `nextAcknowledgements` now and added a test for the same.
Thanks for catching this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
