apoorvmittal10 commented on code in PR #18096: URL: https://github.com/apache/kafka/pull/18096#discussion_r1876124891
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/ShareGroupAutoOffsetResetStrategy.java: ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group; + +import org.apache.kafka.common.config.ConfigDef; +import org.apache.kafka.common.config.ConfigException; +import org.apache.kafka.common.requests.ListOffsetsRequest; +import org.apache.kafka.common.utils.Utils; + +import java.time.Duration; +import java.time.Instant; +import java.util.Arrays; +import java.util.Locale; +import java.util.Objects; +import java.util.Optional; + +public class ShareGroupAutoOffsetResetStrategy { Review Comment: Can we have javadocs please on the class. ########## core/src/main/java/kafka/server/share/ShareFetchUtils.java: ########## @@ -161,6 +161,20 @@ static long offsetForLatestTimestamp(TopicIdPartition topicIdPartition, ReplicaM return timestampAndOffset.get().offset; } + /** + * The method is used to get the offset for the given timestamp for the topic-partition. + * + * @return The offset for the given timestamp. + */ + static long offsetForTimestamp(TopicIdPartition topicIdPartition, ReplicaManager replicaManager, long timestampToSearch, int leaderEpoch) { + Option<FileRecords.TimestampAndOffset> timestampAndOffset = replicaManager.fetchOffsetForTimestamp( + topicIdPartition.topicPartition(), timestampToSearch, Option.empty(), Optional.of(leaderEpoch), true).timestampAndOffsetOpt(); + if (timestampAndOffset.isEmpty()) { + throw new OffsetNotAvailableException("Offset for timestamp: " + timestampToSearch + " not found for topic partition: " + topicIdPartition); + } + return timestampAndOffset.get().offset; + } + Review Comment: Should we send the the isolation level as well instead of `Option.empty()`? Also we can have common method and send respective timestamps from: `offsetForEarliestTimestamp`, `offsetForLatestTimestamp` and `offsetForTimestamp` methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
