snehashisp commented on code in PR #17741:
URL: https://github.com/apache/kafka/pull/17741#discussion_r1876896702
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java:
##########
@@ -367,6 +371,13 @@ public Object newPlugin(String classOrAlias, VersionRange
range) throws Versione
return newPlugin(klass);
}
+ public <T> Object newPlugin(String classOrAlias, Class<T> baseClass,
VersionRange range) throws ClassNotFoundException {
Review Comment:
Yes, it very similar. It requires some changes, but we can use likely the
existing ones during validation but `newPlugin(PluginClassloader, pluginName,
version)` is also useful for finding the plugin and its version while setting
the defaults for the connector config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
